Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent delay_visibility_of_program_deployment feature from cache pruning #33689

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Prevent delay_visibility_of_program_deployment feature from cache pruning #33689

merged 1 commit into from
Oct 13, 2023

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Oct 13, 2023 •
edited by Lichtso
Loading

Problem

Reverting #32974, delay_visibility_of_program_deployment should not trigger pruning of cache at epoch boundary.

Summary of Changes

Remove the feature from the list of features that can trigger the cache pruning.

Fixes #

@pgarg66 pgarg66 added v1.17 PRs that should be backported to v1.17 v1.16 PRs that should be backported to v1.16 labels Oct 13, 2023
@pgarg66 pgarg66 marked this pull request as ready for review October 13, 2023 13:46
@pgarg66 pgarg66 requested a review from Lichtso October 13, 2023 13:46
@pgarg66 pgarg66 added the automerge Merge this Pull Request automatically once CI passes label Oct 13, 2023
@mergify mergify bot merged commit fd92977 into solana-labs:master Oct 13, 2023
31 checks passed
mergify bot pushed a commit that referenced this pull request Oct 13, 2023
@pgarg66 @mergify
Prevent delay_visibility_of_program_deployment feature from cache pru…
062a5cc 
…ning (#33689)

(cherry picked from commit fd92977)

# Conflicts:
#	runtime/src/bank.rs
mergify bot pushed a commit that referenced this pull request Oct 13, 2023
@pgarg66 @mergify
Prevent delay_visibility_of_program_deployment feature from cache pru…
2033a0f 
…ning (#33689)

(cherry picked from commit fd92977)
This was referenced Oct 13, 2023
Merged
Merged
@pgarg66 pgarg66 deleted the delay-visible branch October 13, 2023 14:23
mergify bot added a commit that referenced this pull request Oct 13, 2023
@mergify @pgarg66
v1.17: Prevent delay_visibility_of_program_deployment feature from ca…
c96223b 
…che pruning (backport of #33689) (#33691)

Prevent delay_visibility_of_program_deployment feature from cache pruning (#33689)

(cherry picked from commit fd92977)

Co-authored-by: Pankaj Garg <pankaj@solana.com>
mergify bot added a commit that referenced this pull request Oct 13, 2023
@mergify @pgarg66
v1.16: Prevent delay_visibility_of_program_deployment feature from ca…
fdb432d 
…che pruning (backport of #33689) (#33690)

* Prevent delay_visibility_of_program_deployment feature from cache pruning (#33689)

(cherry picked from commit fd92977)

# Conflicts:
#	runtime/src/bank.rs

* fix merge conflict

---------

Co-authored-by: Pankaj Garg <pankaj@solana.com>
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lichtso Lichtso Lichtso approved these changes

Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes v1.16 PRs that should be backported to v1.16 v1.17 PRs that should be backported to v1.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgarg66 @Lichtso